Use key/value object in place of Array for requests headers #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jancurn
approved these changes
Jan 10, 2024
jancurn
requested changes
Jan 10, 2024
|
yes, so it seems that original implementation with array is to allow repeating headers, and my change break this. |
|
It seems |
|
So it worked fine with the array too, instead of object? The reason why we use array of raw headers is to preserve all even duplicate headers to make the proxy transparent. |
|
The current implementation does not work at all for me (node v20.15.1), the proxy receives headers with an array index as key: opened #547 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across an issue where the
anonymizeProxyhelper function was not working correctly, and upstream proxy was returning 407, even if the username/password was correctly set in the proxy url.I found out that the upstream proxy was not receiving the credential header correctly.
httpandhttpsrequest should contain header according to the API.With the proposed changes, the
anonymizeProxyworks correctly, and I no longer have errors