Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proxy headers are using the array index as key #547

Closed
mschfh opened this issue Aug 16, 2024 · 3 comments
Closed

proxy headers are using the array index as key #547

mschfh opened this issue Aug 16, 2024 · 3 comments
Labels
backend Issues related to the platform backend. bug Something isn't working. medium priority Medium priority issues to be done in a couple of sprints. t-platform Issues with this label are in the ownership of the platform team. validated Issues that are resolved and their solutions fulfill the acceptance criteria.

Comments

@mschfh
Copy link

mschfh commented Aug 16, 2024

The proxy receives headers with an array index as key:

CONNECT www.ifconfig.co:443 HTTP/1.1
0: host
1: www.ifconfig.co:443
2: proxy-authorization
3: Basic Zm9vOmJhcg==
Host: 192.168.1.1:1234
Connection: keep-alive

expected:

CONNECT www.ifconfig.co:443 HTTP/1.1
host: www.ifconfig.co:443
proxy-authorization: Basic Zm9vOmJhcg==
...

There was an attempt to fix this in #528, but the PR was abandoned.
@mschfh mschfh changed the title requests headers are using the array index as key proxy headers are using the array index as key Aug 16, 2024
@mschfh mschfh mentioned this issue Aug 20, 2024
Closed
@mschfh
Copy link
Author

mschfh commented Aug 20, 2024

@jirimoravcik Could you please take a look at this one too?

@fnesveda fnesveda added the t-platform Issues with this label are in the ownership of the platform team. label Aug 21, 2024
@jirimoravcik
Copy link
Member

jirimoravcik commented Aug 21, 2024 •
edited
Loading

Hey, can you please provide full reproduction example and the problem with it? We have been using the array structure for headers and it has been working for us. Also please provide packages used along with Node.js version.

@fnesveda fnesveda added bug Something isn't working. medium priority Medium priority issues to be done in a couple of sprints. backend Issues related to the platform backend. labels Aug 21, 2024
@mschfh
Copy link
Author

mschfh commented Aug 21, 2024

This issue was caused by the Sentry httpIntegration, it might not be a bug in proxy-chain.

@mschfh mschfh closed this as not planned Won't fix, can't repro, duplicate, stale Aug 21, 2024
@jirimoravcik jirimoravcik added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Aug 26, 2024
@fduman fduman mentioned this issue Sep 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend Issues related to the platform backend. bug Something isn't working. medium priority Medium priority issues to be done in a couple of sprints. t-platform Issues with this label are in the ownership of the platform team. validated Issues that are resolved and their solutions fulfill the acceptance criteria.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jirimoravcik @fnesveda @mschfh