[YUNIKORN-2974] Expose preemption and priority settings via REST #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add preemption and priority details to the queue REST information. Currently the configuration is exposed via the properties. The properties contain the raw configuration values which need to be interpreted. Invalid configuration values are ignored and not set on the queue. This could cause an incorrect view of what is or should be active on the queue if based on the properties. Using the active values from the object to show the real state. Expose Partition level preemption flag as part of this change to complement the queue details.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #995 +/- ##
==========================================
+ Coverage 81.33% 81.34% +0.01%
==========================================
Files 97 97
Lines 15587 15597 +10
==========================================
+ Hits 12678 12688 +10
Misses 2630 2630
Partials 279 279 ☔ View full report in Codecov by Sentry. |
brandboat
reviewed
Nov 15, 2024
| queueInfo.AbsUsedCapacity = resources.CalculateAbsUsedCapacity(sq.maxResource, sq.allocatedResource).DAOMap() | ||
| queueInfo.SortingPolicy = sq.sortType.String() | ||
| queueInfo.PrioritySorting = sq.prioritySortEnabled | ||
| queueInfo.PreemptionEnabled = sq.preemptionPolicy == policies.DisabledPreemptionPolicy |
There was a problem hiding this comment.
I am a bit misleading here, does PreemptionEnabled = true means the preemptionPolicy is disabled ?
There was a problem hiding this comment.
I believe this should be sq.preemptionPolicy != policies.DisabledPreemptionPolicy
craigcondit
requested changes
Nov 15, 2024
pbacsko
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Add preemption and priority details to the queue REST information. Currently the configuration is exposed via the properties. The properties contain the raw configuration values which need to be interpreted.
Invalid configuration values are ignored and not set on the queue. This could cause an incorrect view of what is or should be active on the queue if based on the properties. Using the active values from the object to show the real state.
Expose Partition level preemption flag as part of this change to complement the queue details.
What type of PR is it?
What is the Jira issue?
YUNIKORN-2976
How should this be tested?
new unit tests added
Questions: