[YUNIKORN-2967] Cleanup REST response headers #994
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only respond with the allowed methods for the request, not with a general all allowed set. OPTIONS is supported via the generic config. Add a test to make sure a change in router does not break that. Remove the Access-Control-Allow-Credentials as recommended in the RFC. We also do not use cookies or authentication so not relevant to set.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #994 +/- ##
==========================================
- Coverage 81.33% 81.32% -0.02%
==========================================
Files 97 97
Lines 15587 15590 +3
==========================================
Hits 12678 12678
- Misses 2630 2632 +2
- Partials 279 280 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Only respond with the allowed methods for the request, not with a general all allowed set. OPTIONS is supported via the generic config. Add a test to make sure a change in router does not break that.
Remove the Access-Control-Allow-Credentials as recommended in the RFC. We also do not use cookies or authentication so not relevant to set.
What type of PR is it?
What is the Jira issue?
How should this be tested?
New unit tests added