[YUNIKORN-2953] Placeholder release count incorrect #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While releasing placeholders the allocated placeholders are counted twice in the tracking information. With YUNIKORN-2926 in place this happens if some but not all placeholders are allocated only. Mark unallocated placeholders that timeout as released to prevent scheduling issues.
wilfred-s
requested review from
manirajv06,
chia7712,
lixmgl,
zhuqi-lucas,
craigcondit,
pbacsko and
steinsgateted
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #991 +/- ##
==========================================
+ Coverage 81.46% 81.50% +0.03%
==========================================
Files 97 97
Lines 15511 15520 +9
==========================================
+ Hits 12636 12649 +13
+ Misses 2595 2592 -3
+ Partials 280 279 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
While releasing placeholders the allocated placeholders are counted twice in the tracking information. With YUNIKORN-2926 in place this happens if some but not all placeholders are allocated only.
Mark unallocated placeholders that timeout as released to prevent scheduling issues.
What type of PR is it?
What is the Jira issue?
How should this be tested?
This fixes should make a failing e2e test pass: gangscheduling_test