Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2951] Remove unnecessary locking from RequiredNodePreemptor #989

Closed
wants to merge 1 commit into from

Conversation

ryankert01
Copy link
Contributor

What is this PR for?

RequiredNodePreemptor use lock at some places before doing read and write at some places. Based on the assessment, there is no reason to use locks and should be removed.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2951

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@5d3eb36). Learn more about missing BASE report.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #989   +/-   ##
=========================================
  Coverage          ?   81.24%           
=========================================
  Files             ?       97           
  Lines             ?    15460           
  Branches          ?        0           
=========================================
  Hits              ?    12561           
  Misses            ?     2617           
  Partials          ?      282           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@craigcondit craigcondit changed the title [YUNIKORN-2951] RequiredNodePreemptor doesn't require lock [YUNIKORN-2951] Remove unnecessary locking from RequiredNodePreemptor Oct 29, 2024
craigcondit

This comment was marked as duplicate.

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

@ryankert01 ryankert01 deleted the YUNIKORN-2951 branch October 30, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants