Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2887] Optimize sortApplications function code #974

Closed
wants to merge 1 commit into from

Conversation

hiwangzhihui
Copy link
Contributor

@hiwangzhihui hiwangzhihui commented Sep 24, 2024

What is this PR for?

  • Optimize sortApplications function code
  • Only apps that have "pending resources" in the queue can participate in scheduling.

What type of PR is it?

  • Improvement

https://issues.apache.org/jira/browse/YUNIKORN-2887

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.03%. Comparing base (5e3535c) to head (d5e20e8).
Report is 70 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #974      +/-   ##
==========================================
+ Coverage   78.01%   81.03%   +3.01%     
==========================================
  Files          97       97              
  Lines       12119    12523     +404     
==========================================
+ Hits         9455    10148     +693     
+ Misses       2354     2104     -250     
+ Partials      310      271      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants