[YUNIKORN-2450]Rename updateLowestId to updateLowestID, TestLoggerIds to TestLoggerIDs #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #973 +/- ##
=========================================
Coverage ? 81.03%
=========================================
Files ? 97
Lines ? 12525
Branches ? 0
=========================================
Hits ? 10150
Misses ? 2104
Partials ? 271 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Rename
updateLowestIdtoupdateLowestID,TestLoggerIdstoTestLoggerIDsThis is follow-up of https://issues.apache.org/jira/browse/YUNIKORN-2413
The methods are shown below.
https://github.com/apache/yunikorn-core/blob/master/pkg/events/event_ringbuffer.go#L206
https://github.com/apache/yunikorn-core/blob/master/pkg/log/logger_test.go#L38
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2450
How should this be tested?
It should pass all unit tests
Screenshots (if appropriate)
Questions: