added og and twitter metadata #293
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just pushed this to the apache/preview/og-metadata branch to generate a preview. After the build finishes, the result can be found at https://www-og-metadata.staged.apache.org/ |
rlenferink
reviewed
Aug 17, 2023
theme/apache/templates/base.html
Outdated
| <meta property="og:url" content="https://www.apache.org/"> | ||
| <meta property="og:type" content="website"> | ||
| <meta property="og:title" content="{{ page.title }}"> | ||
| <meta property="og:description" content="Home page of The Apache Software Foundation"> |
There was a problem hiding this comment.
This base.html is used as template for multiple pages besides the home page. Maybe this description can be made more generic (or using an auto generated page description maybe) ?
There was a problem hiding this comment.
I have added the support to give descriptions from individual pages just like title. I have also put a description in siteindex page in-order to test it. @rlenferink if you could update the branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #268
I would like to test it on preview branch first