Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOMEE-2247 - MicroProfile JWT Propagation 1.1 #173

Merged
merged 36 commits into from
Dec 10, 2018

Conversation

radcortez
Copy link
Contributor

No description provided.

@jeanouii
Copy link
Contributor

jeanouii commented Dec 4, 2018

@radcortez where are we at?
There is a conflict and I'm not sure you have seen it

@radcortez
Copy link
Contributor Author

Hey @jeanouii,

This was on hold, because @jgallimore picked this up and continue the work on his own branch here:
https://github.com/jgallimore/tomee/commits/jwt-1.1

Since he is done, I'm rebasing this with his branch and push an updated PR.

Due to this:
eclipse/microprofile-jwt-auth#118

A few test cases in the TCK are failing. I believe this is an issue with the TCK itself. I think we can still test this if we implement our own tests with a separate app to expose the JWK endpoint. Me and @jgallimore discussed this on the ML and so I will be picking this up and hopefully complete the JWT 1.1 implementation work.

@jeanouii
Copy link
Contributor

jeanouii commented Dec 7, 2018

So what do we do?
Do we leave this open?

@radcortez
Copy link
Contributor Author

@jeanouii this work should now be complete. I've sent an email about this to the ML. I think we can merge it.

jgallimore and others added 11 commits December 7, 2018 18:13
…state all tests. Couple of failing JWT tests to go
…ods we use, so excluding it from the packaging here.
…e application start, but from the spec if the key is not present we need to fail with a Deployment Exception, so the key needs to be loaded eagerly.
…ects application to be deployed to load the key, but key load is part of the deployment, so the key endpoint cannot be part of the app being tested.
Copy link
Contributor

@brunobat brunobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executed the tests in the project and the bundled TCK project and they pass

@asfgit asfgit merged commit c3ad279 into apache:master Dec 10, 2018
asfgit pushed a commit that referenced this pull request Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants