-
Notifications
You must be signed in to change notification settings - Fork 467
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[SYSTEMDS-3610] BuiltinSwitch Aggregate Skip
This commit provide a minor minor change to the Builtin instructions to include min and max. The difference in performance is negligible but there, so we include the improvement. Closes #1875
- Loading branch information
1 parent
2ff4b28
commit 6b3a6ce
Showing
3 changed files
with
109 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 52 additions & 0 deletions
52
src/main/java/org/apache/sysds/runtime/functionobjects/Max.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
package org.apache.sysds.runtime.functionobjects; | ||
|
||
public class Max extends Builtin { | ||
private static Max singleObj = null; | ||
|
||
private Max() { | ||
super(BuiltinCode.MAX); | ||
// nothing to do here. | ||
} | ||
|
||
private static final long serialVersionUID = 6529946102263905602L; | ||
|
||
public static Max getMaxFnObject() { | ||
if(singleObj == null) | ||
singleObj = new Max(); | ||
return singleObj; | ||
} | ||
|
||
@Override | ||
public boolean execute(boolean in1, boolean in2) { | ||
return in1 || in2; | ||
} | ||
|
||
@Override | ||
public double execute(long in1, long in2) { | ||
return Math.max(in1, in2); | ||
} | ||
|
||
@Override | ||
public double execute(double in1, double in2) { | ||
return Math.max(in1, in2); | ||
} | ||
} |
52 changes: 52 additions & 0 deletions
52
src/main/java/org/apache/sysds/runtime/functionobjects/Min.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
package org.apache.sysds.runtime.functionobjects; | ||
|
||
public class Min extends Builtin { | ||
private static Min singleObj = null; | ||
|
||
private Min() { | ||
super(BuiltinCode.MIN); | ||
// nothing to do here. | ||
} | ||
|
||
private static final long serialVersionUID = 6529946102263905602L; | ||
|
||
public static Min getMinFnObject() { | ||
if(singleObj == null) | ||
singleObj = new Min(); | ||
return singleObj; | ||
} | ||
|
||
@Override | ||
public boolean execute(boolean in1, boolean in2) { | ||
return !(!in1 || !in2); | ||
} | ||
|
||
@Override | ||
public double execute(long in1, long in2) { | ||
return Math.min(in1, in2); | ||
} | ||
|
||
@Override | ||
public double execute(double in1, double in2) { | ||
return Math.min(in1, in2); | ||
} | ||
} |