[SPARK-50977][CORE] Enhance availability of logic performing aggregation of accumulator results #49618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costas-db
changed the title
…as-db/spark into refactorMetrics
utkarsh39
approved these changes
Jan 24, 2025
HyukjinKwon
changed the title
HyukjinKwon
approved these changes
Jan 25, 2025
|
Merged to master and branch-4.0. |
HyukjinKwon
added a commit
that referenced
this pull request
Jan 28, 2025
…ion of accumulator results ### What changes were proposed in this pull request? In this PR we introduce a minor refactor that enhances the availability of the functionality used to perform aggregation of accumulator results. ### Why are the changes needed? These changes make the aggregation logic accessible from other modules which enables various memory and disk optimizations. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? This is a minor refactor. No new code has been added, therefore no new tests are needed. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49618 from costas-db/costas-zarifis_data/refactorMetrics. Lead-authored-by: Costas Zarifis <[email protected]> Co-authored-by: Costas Zarifis <[email protected]> Co-authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit a452e1b) Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In this PR we introduce a minor refactor that enhances the availability of the functionality used to perform aggregation of accumulator results.
Why are the changes needed?
These changes make the aggregation logic accessible from other modules which enables various memory and disk optimizations.
Does this PR introduce any user-facing change?
No
How was this patch tested?
This is a minor refactor. No new code has been added, therefore no new tests are needed.
Was this patch authored or co-authored using generative AI tooling?
No.