-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-50917][EXAMPLES] Add SparkSQLPi Scala example to work both for Connect and Classic #49617
base: master
Are you sure you want to change the base?
Conversation
cc @cloud-fan @dongjoon-hyun @HyukjinKwon, thank you! |
make sense |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand what you aim, but this is not SQL
in a user perspective, @yaooqinn .
We should distinguish SQL
vs Spark Connect
because Apache Spark already has Spark SQL
modules and user interfaces like JDBC and spark-sql
shell. Could you revise the name, 😄 ?
I'd rename it with the FQDN as org.apache.spark.examples.sql.connect.SparkConnectPi |
Thank you. Please revise the PR title and description accordingly too. |
What changes were proposed in this pull request?
This PR adds SparkSQLPi Scala example to work both for Connect and Classic
Why are the changes needed?
The SparkPi example, mostly as the first step for users to get to know Spark, should be able to run on Spark Connect mode.
Does this PR introduce any user-facing change?
no
How was this patch tested?
Manually build and test
Was this patch authored or co-authored using generative AI tooling?
no