[SPARK-48289][DOCKER][TEST] Clean up Oracle JDBC tests by skipping redundant SYSTEM password reset #46598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…redundant and ca trigger ORA-04031
|
cc @yaooqinn |
|
Feel free to merge, @yaooqinn . |
yaooqinn
reviewed
May 16, 2024
...ker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/OracleNamespaceSuite.scala
Outdated
Show resolved
Hide resolved
…park/sql/jdbc/v2/OracleNamespaceSuite.scala
yaooqinn
reviewed
May 16, 2024
...r-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/OracleIntegrationSuite.scala
Outdated
Show resolved
Hide resolved
…park/sql/jdbc/v2/OracleIntegrationSuite.scala
yaooqinn
reviewed
May 16, 2024
...cker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala
Outdated
Show resolved
Hide resolved
…park/sql/jdbc/OracleIntegrationSuite.scala
|
Thank @LucaCanali @dongjoon-hyun Merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pull request improves the Oracle JDBC tests by skipping the redundant SYSTEM password reset.
Why are the changes needed?
These changes are necessary to clean up the Oracle JDBC tests.
This pull request effectively reverts the modifications introduced in SPARK-46592 and PR #44594, which attempted to work around the sporadic occurrence of ORA-65048 and ORA-04021 errors by setting the Oracle parameter DDL_LOCK_TIMEOUT.
As discussed in issue #35, setting DDL_LOCK_TIMEOUT did not resolve the issue. The root cause appears to be an Oracle bug or unwanted behavior related to the use of Pluggable Database (PDB) rather than the expected functionality of Oracle itself.
Additionally, with SPARK-48141, we have upgraded the Oracle version used in the tests to Oracle Free 23ai, version 23.4. This upgrade should help address some of the issues observed with the previous Oracle version.
Does this PR introduce any user-facing change?
No
How was this patch tested?
This patch was tested using the existing test suite, with a particular focus on Oracle JDBC tests. The following steps were executed:
Was this patch authored or co-authored using generative AI tooling?
No