SOLR-17618: Add unit tests for org.apache.solr.util.TimeOut #3026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandbergja
force-pushed
the
timeout-tests
branch
2 times, most recently
from
492fe05 to
46da013
Compare
This class did not appear to have any unit tests yet.
sandbergja
force-pushed
the
timeout-tests
branch
from
46da013 to
387b944
Compare
madrob
reviewed
Jan 12, 2025
| } | ||
|
|
||
| public void testHasTimedOut() { | ||
| TimeSource mockTimeSource = mock(TimeSource.class); |
There was a problem hiding this comment.
This could go in a Before method
There was a problem hiding this comment.
Ooh, good point! Thanks, @madrob !
There was a problem hiding this comment.
I would do Before, not BeforeClass for it, and also put the when/thenReturn line in there as well.
Then in the tests adjust the timeouts to test various combinations if we have the same mock time source each time. Does that make sense?
There was a problem hiding this comment.
Okay! I think I get it now. Thanks for working with me on this @madrob !
* Add @test annotations * Move repeated mock setup to Before method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class did not appear to have any unit tests yet.
https://issues.apache.org/jira/browse/SOLR-17618
Description
Adding some unit tests for
org.apache.solr.util.TimeOut, which did not have unit tests previously (although I believe the tests exercise it in other ways).Solution
Adding a few simple tests
Tests
The attached unit tests pass for me, no functionality changes are included in this pull request.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.