Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-17556: Fix smokeTest to use films as example for slim distribution #3020

Merged

Conversation

HoustonPutman
Copy link
Contributor

fixes for - SOLR-17556

(cherry picked from commit 80dfe11)

The initial commit fixed the smoke test script to not use the techproducts example for the slim distribution. In main the test_utf8 script was already removed, so I removed that here as well. I also removed the data, which required changing a few tests to fit the 1 less document.

More important, I also added the ability to set the solr home directory for examples. this is important for testing, but is much better than modifying the server directory in solr.

Will forward port the differences from the original commit to main if it's approved.

Also remove test_utf8 from the smoke test, and the data for the test.

(cherry picked from commit 80dfe11)
Copy link
Contributor

@epugh epugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes all make sense from the perspective of backporting and assuming that techproducts isn't part of the slim distro, but films is.

One thought? Should the "slim" distribution come with ANY examples? I could understand that the slim one has no examples... Maybe, if you wanted to smoke test the "slim" distribution, you would just index the data from the regular distribution, but not include it in the download?

@HoustonPutman
Copy link
Contributor Author

Yeah , I guess we could do that with the examples-dir option. Originally i had removed the examples when adding the slim distribution, but left it in to not disrupt the testing methodology too much

@HoustonPutman
Copy link
Contributor Author

For 9x we shouldnt remove it though. Just for 10

Copy link
Contributor

@anshumg anshumg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for taking care of this @HoustonPutman

@HoustonPutman HoustonPutman merged commit 9d67ad6 into apache:branch_9x Jan 10, 2025
4 checks passed
@HoustonPutman HoustonPutman deleted the fix-examples-smoketest branch January 10, 2025 17:02
HoustonPutman added a commit that referenced this pull request Jan 10, 2025
…on (#3020)

Also remove test_utf8 from the smoke test, and the data for the test.
Added the ability to set the solr home directory for examples. this is important for testing, but is much better than modifying the server directory in solr.

(cherry picked from commit 80dfe11)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants