Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOLR-17595: Backport "Fix Solr examples for Windows" #2911

Merged
merged 3 commits into from
Dec 18, 2024
Merged

SOLR-17595: Backport "Fix Solr examples for Windows" #2911

merged 3 commits into from
Dec 18, 2024

Conversation

malliaridis
Copy link
Contributor

@malliaridis malliaridis commented Dec 17, 2024 •
edited
Loading

https://issues.apache.org/jira/browse/SOLR-17595

Description

This is the backport for the fixes from #2909.

Tests

I have manually tested this backport PR to make sure the examples are working fine. Tested techproducts and cloud with

>bin\solr.cmd start -e techproducts
# and
>bin\solr.cmd start -e cloud

Both are executed successful and created the expected collections.

Checklist

Please review the following and check all that apply:

  • X] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

@malliaridis
Fix argument parsing for -D options with multiple values on Windows
1e9bcb7 
(cherry picked from commit 44ea44d)
@malliaridis
SOLR-17595: Fix Solr examples for Windows (apache#2909)
9a6a4ab 
* Fix argument parsing for -D options with multiple values on Windows

* Fix invalid usage of wildcards in RunExampleTool / PostTool

(cherry picked from commit a4229e7)
@malliaridis
Fix unsupported method
caeef75
epugh
epugh approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@epugh epugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@malliaridis malliaridis merged commit 9440ec1 into apache:branch_9x Dec 18, 2024
4 checks passed
malliaridis added a commit that referenced this pull request Dec 18, 2024
@malliaridis
SOLR-17595: Backport "Fix Solr examples for Windows" (#2911)
a86d50d 
* Fix argument parsing for -D options with multiple values on Windows

(cherry picked from commit 44ea44d)

* SOLR-17595: Fix Solr examples for Windows (#2909)

* Fix argument parsing for -D options with multiple values on Windows

* Fix invalid usage of wildcards in RunExampleTool / PostTool

(cherry picked from commit a4229e7)

* Fix unsupported method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epugh epugh epugh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malliaridis @epugh