[type:feat]Alert module adapts to namespace transformation #5692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moremind
requested changes
Oct 21, 2024
| import org.springframework.web.bind.annotation.RequestParam; | ||
|
|
||
| import jakarta.validation.Valid; |
| @@ -156,6 +156,12 @@ private List<AlertReceiverDTO> matchReceiverByRules(final AlarmContent alert) { | |||
| return true; | |||
| } | |||
|
|
|||
| if (!Objects.isNull(item.getNamespaceId())) { | |||
| @Override | ||
| public void deleteReceiver(final List<String> ids) { | ||
| public void deleteByNamespaceId(final List<String> ids, final String namespaceId) { |
There was a problem hiding this comment.
rename the method deleteReceiverByNamespaceId
|
pls modify these changes, and check the alert module for shenyu-bootstrap |
xcsnx
requested changes
Oct 22, 2024
| @@ -75,61 +77,122 @@ public static void alarm(final AlarmContent alarmContent) { | |||
| * @param labels Alarm labels | |||
| */ | |||
| public static void alarm(final byte level, final String title, final String content, final Map<String, String> labels) { | |||
| alarm(level, title, content, labels, SYS_DEFAULT_NAMESPACE_ID); | |||
There was a problem hiding this comment.
This should not be a fixed ‘SYS_DEFAULT_NAMESPACE_ID’
… into feat_namespace_alert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that: