removing sqlCommentParseEnabled config in SQLParser rule #29575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strongduanmu
approved these changes
Dec 28, 2023
| @@ -31,15 +31,15 @@ class SQLStatementParserEngineFactoryTest { | |||
|
|
|||
| @Test | |||
| void assertGetSQLStatementParserEngineNotSame() { | |||
| SQLStatementParserEngine before = SQLStatementParserEngineFactory.getSQLStatementParserEngine(databaseType, new CacheOption(2000, 65535L), new CacheOption(128, 1024L), false); | |||
| SQLStatementParserEngine after = SQLStatementParserEngineFactory.getSQLStatementParserEngine(databaseType, new CacheOption(2000, 65535L), new CacheOption(128, 1024L), true); | |||
| SQLStatementParserEngine before = SQLStatementParserEngineFactory.getSQLStatementParserEngine(databaseType, new CacheOption(2000, 65535L), new CacheOption(64, 1024L)); | |||
There was a problem hiding this comment.
This test class is for testing the getSqlStatementParserEngine method. If the parameters are different, assertNotSame(before, after) should be used. Originally, the sqlCommentParseEnabled parameter was different: true in before and false in after. In the new code, this parameter sqlCommentParseEnabled has been removed, so the test case needs to be adjusted.
| @@ -521,8 +521,8 @@ public int[] executeBatch() throws SQLException { | |||
|
|
|||
| private QueryContext createQueryContext(final String originSQL) { | |||
| SQLParserRule sqlParserRule = metaDataContexts.getMetaData().getGlobalRuleMetaData().getSingleRule(SQLParserRule.class); | |||
| String sql = sqlParserRule.isSqlCommentParseEnabled() ? originSQL : SQLHintUtils.removeHint(originSQL); | |||
| HintValueContext hintValueContext = sqlParserRule.isSqlCommentParseEnabled() ? new HintValueContext() : SQLHintUtils.extractHint(originSQL).orElseGet(HintValueContext::new); | |||
| String sql = SQLHintUtils.removeHint(originSQL); | |||
There was a problem hiding this comment.
There is a judgment of 'startWith' in removeHint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29535.
Changes proposed in this pull request:
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.