Skip to content

Commit

Permalink
Revise #33024
Browse files Browse the repository at this point in the history
  • Loading branch information
terrymanu committed Sep 27, 2024
1 parent d03931f commit 5558c62
Showing 1 changed file with 4 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -266,18 +266,17 @@ public void setReadOnly(final boolean readOnly) throws SQLException {
}

/*
* This is just to avoid the Warning in <a href="https://github.com/brettwooldridge/HikariCP/issues/2196">brettwooldridge/HikariCP#2196</a>.
* ShardingSphere does not propagate this property to the real JDBC Driver.
* `0` is actually the default value of {@link java.net.Socket#getSoTimeout()}.
* This is just to avoid the Warning in <a href="https://github.com/brettwooldridge/HikariCP/issues/2196">brettwooldridge/HikariCP#2196</a>. ShardingSphere does not propagate this property to the
* real JDBC Driver. `0` is actually the default value of {@link java.net.Socket#getSoTimeout()}.
*/
@Override
public int getNetworkTimeout() {
return 0;
}

/*
* This is just to avoid the Warning in <a href="https://github.com/brettwooldridge/HikariCP/issues/2196">brettwooldridge/HikariCP#2196</a>.
* ShardingSphere does not propagate this property to the real JDBC Driver.
* This is just to avoid the Warning in <a href="https://github.com/brettwooldridge/HikariCP/issues/2196">brettwooldridge/HikariCP#2196</a>. ShardingSphere does not propagate this property to the
* real JDBC Driver.
*/
@Override
public void setNetworkTimeout(final Executor executor, final int milliseconds) throws SQLException {
Expand Down

0 comments on commit 5558c62

Please sign in to comment.