Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4477]Fix GoAway issue in Http2 after many requests timeout #4487

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

liubao68
Copy link
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@yanghao605
Copy link
Contributor

这个改法是判断连接是否closed来决定服务端是否调用end方法,推送数据,这里跳过end方法是否会对服务端的连接产生影响?

@liubao68
Copy link
Contributor Author

liubao68 commented Sep 2, 2024

这个改法是判断连接是否closed来决定服务端是否调用end方法,推送数据,这里跳过end方法是否会对服务端的连接产生影响?

closed意味着早已经end, 这个是没问题的。

@liubao68 liubao68 merged commit 06ff2f0 into apache:master Sep 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants