[#4074] optimize cors model init failed unclear prompt problem. #4095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liubao68
reviewed
Dec 6, 2023
| @@ -85,16 +86,16 @@ public static <CLIENT_POOL> DeploymentOptions createClientDeployOptions( | |||
| } | |||
|
|
|||
| // deploy Verticle and wait for its success. do not call this method in event-loop thread | |||
| public static <VERTICLE extends Verticle> boolean blockDeploy(Vertx vertx, | |||
| public static <VERTICLE extends Verticle> Map<String, String> blockDeploy(Vertx vertx, | |||
There was a problem hiding this comment.
return Map<String, Object> to avoid data type convert
liubao68
reviewed
Dec 6, 2023
| VertxUtils.blockDeploy(vertx, ClientVerticle.class, deployOptions); | ||
| Map<String, String> result = VertxUtils.blockDeploy(vertx, ClientVerticle.class, deployOptions); | ||
| if (!Boolean.parseBoolean(result.get("code"))) { | ||
| throw new Exception(result.get("message")); |
There was a problem hiding this comment.
throw new IllegalStageException
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.8.x #4095 +/- ##
============================================
+ Coverage 74.13% 74.16% +0.03%
Complexity 707 707
============================================
Files 1598 1594 -4
Lines 40255 40153 -102
Branches 3676 3659 -17
============================================
- Hits 29842 29779 -63
+ Misses 8920 8888 -32
+ Partials 1493 1486 -7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.