Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4054] make the operationConfig lazy to load #4056

Closed
wants to merge 1 commit into from

Conversation

yanghao605
Copy link
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@liubao68
Copy link
Contributor

Would you mind create an PR first for master and than cherry-pick to 2.8.x?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (76854ff) 74.14% compared to head (6c7023b) 74.14%.

❗ Current head 6c7023b differs from pull request most recent head aa498fc. Consider uploading reports for the commit aa498fc to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              2.8.x    #4056   +/-   ##
=========================================
  Coverage     74.14%   74.14%           
  Complexity      707      707           
=========================================
  Files          1598     1598           
  Lines         40252    40251    -1     
  Branches       3675     3675           
=========================================
  Hits          29844    29844           
  Misses         8917     8917           
+ Partials       1491     1490    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yanghao605
Copy link
Contributor Author

Would you mind create an PR first for master and than cherry-pick to 2.8.x?

OK

@yanghao605 yanghao605 closed this Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants