Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3960]fix vertx close may block shutdown #3965

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

liubao68
Copy link
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #3965 (8c88c18) into 2.8.x (863e887) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

❗ Current head 8c88c18 differs from pull request most recent head 0be5c46. Consider uploading reports for the commit 0be5c46 to get more accurate results

@@             Coverage Diff              @@
##              2.8.x    #3965      +/-   ##
============================================
- Coverage     74.23%   74.21%   -0.02%     
  Complexity      703      703              
============================================
  Files          1597     1597              
  Lines         40170    40170              
  Branches       3669     3669              
============================================
- Hits          29820    29814       -6     
- Misses         8860     8864       +4     
- Partials       1490     1492       +2     
Files Coverage Δ
...pache/servicecomb/foundation/vertx/VertxUtils.java 78.75% <66.66%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@liubao68 liubao68 merged commit 4f59e71 into apache:2.8.x Oct 10, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants