Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-2800]remove discovery and config implementation from solution-basic #3878

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

liubao68
Copy link
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #3878 (377c951) into master (f24d3c8) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 377c951 differs from pull request most recent head a9dba8f. Consider uploading reports for the commit a9dba8f to get more accurate results

@@             Coverage Diff              @@
##             master    #3878      +/-   ##
============================================
- Coverage     43.57%   43.57%   -0.01%     
+ Complexity     5969     5967       -2     
============================================
  Files          1534     1534              
  Lines         37966    37966              
  Branches       3537     3537              
============================================
- Hits          16545    16543       -2     
- Misses        20117    20118       +1     
- Partials       1304     1305       +1     

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@liubao68 liubao68 merged commit c54ed6f into apache:master Jul 25, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants