Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-193] Refactor MakeEmptyRaster to allow setting custom datatype #957

Merged

Conversation

iGN5117
Copy link
Contributor

@iGN5117 iGN5117 commented Aug 10, 2023

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

  • Refactor RS_MakeEmptyRaster to allow setting a custom datatype for the raster. Currently, all rasters created have double value.
  • This PR allows setting 1 datatype out of (Double, Float, int32, short16, usigned_short16, and byte) for all current (and future) bands of the raster. Making a raster with different datatypes for all the bands is not supported, due to our usage of WritableRaster.

How was this patch tested?

  • Added additional tests

Did this PR include necessary documentation updates?

@jiayuasu jiayuasu added this to the sedona-1.5.0 milestone Aug 11, 2023
@jiayuasu jiayuasu merged commit 7d18456 into apache:master Aug 11, 2023
39 checks passed
Kontinuation pushed a commit to Kontinuation/sedona that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants