-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SEDONA-323] Add keplergl wrapper #898
[SEDONA-323] Add keplergl wrapper #898
Conversation
Added a utilities file that hardcodes map config
…github.com/iGN5117/sedona into develop_Nilesh_1.5.0_NotebookVisualization
…github.com/iGN5117/sedona into develop_Nilesh_1.5.0_NotebookVisualization # Conflicts: # binder/ApacheSedonaSQL_SpatialJoin_AirportsPerCountry.ipynb
Clean up jupyter notebook
…ization # Conflicts: # binder/ApacheSedonaSQL_SpatialJoin_AirportsPerCountry.ipynb
Added comments and documentation on using SedonaKepler Added keplergl to sedona/python pipfile Added SedonaKepler import to SedonaContext init Added basic test cases for map created by SedonaKepler Reverted jupyter notebook example to sedona 1.4.1 compatible example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this test to python/tests/maps/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
python/__init__.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is not needed as the Python
folder per se is not a package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was not intended to be added, removed this.
Removed unnecessary init.py in python Refactored method names to follow python convention
Add comprehensive test cases for SedonaKepler
…on 3.7 Updated tests Refactored naming schemes
### Setting a config via the map | ||
A map rendered by accessing the map object created by SedonaKepler includes a config panel which can be used to customize the map | ||
|
||
<img src="../../image/sedona_customization.gif" width="1000"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iGN5117 This doc references to this image but this image was not committed together with this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about that, pushed the gif
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject
.What changes were proposed in this PR?
How was this patch tested?
Did this PR include necessary documentation updates?