Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] add contributing file #1750

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Conversation

MrPowers
Copy link
Contributor

@MrPowers MrPowers commented Jan 9, 2025

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

Fixes #1728.

What changes were proposed in this PR?

Adds a CONTRIBUTING file, as recommended by GitHub.

How was this patch tested?

N/A.

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the documentation.

@MrPowers MrPowers requested a review from jiayuasu as a code owner January 9, 2025 14:10
@github-actions github-actions bot added the root label Jan 9, 2025
@jiayuasu
Copy link
Member

jiayuasu commented Jan 9, 2025

@MrPowers can you run pre-commit run --all-files locally to fix the lint issue?

@james-willis
Copy link
Contributor

Are you duplicating the contents here? https://sedona.apache.org/latest/community/contact/

Some of the contents contradict what is present there as well.

@MrPowers
Copy link
Contributor Author

@jiayuasu - I ran that command and pushed up the fix, thank you!

@james-willis - I tried my best to make them consistent, but perhaps need to make some tweaks. I just took another look and nothing jumped out. Anything in particular you think I should update? Thanks for reviewing!

@james-willis
Copy link
Contributor

I think im objecting to the "Did you create a PR to fix a bug?" section. I think you need to just fill out the template, not write in the description which issues youre addressing. Issue ID will go in the title in brackets at the start.

@MrPowers
Copy link
Contributor Author

@james-willis - I updated that section, let me know if it looks better now. Thanks for reviewing!

@jiayuasu jiayuasu changed the title add contributing file [DOCS] add contributing file Jan 16, 2025
@jiayuasu jiayuasu merged commit b90c96e into apache:master Jan 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CONTRIBUTING file
3 participants