Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add pre-commit hook isort to sort Python imports #1633

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

jbampton
Copy link
Member

"isort is a Python utility / library to sort imports alphabetically and automatically separate into sections and by type."

https://github.com/PyCQA/isort

https://pycqa.github.io/isort/docs/configuration/pre-commit.html

https://pycqa.github.io/isort/docs/configuration/black_compatibility.html

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

  • No.

What changes were proposed in this PR?

Added another check/test to our pre-commit framework to sort Python imports.

How was this patch tested?

Ran locally: pre-commit run --all-files

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the documentation.

@jbampton jbampton marked this pull request as ready for review October 12, 2024 06:36
@jiayuasu jiayuasu merged commit 37f8132 into apache:master Oct 13, 2024
29 checks passed
@jbampton jbampton deleted the add-pre-commit-hook-isort branch October 13, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants