Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Upgrade pre-commit min version; add hook; pre-commit autoupdate #1614

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

jbampton
Copy link
Member

@jbampton jbampton commented Oct 8, 2024

https://github.com/pre-commit/pre-commit-hooks/releases/tag/v5.0.0

pre-commit-hooks now requires pre-commit>=3.2.0

https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#check-illegal-windows-names

https://pre-commit.com/#pre-commit-autoupdate

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

  • No, this is a documentation update. The PR name follows the format [DOCS] my subject.

What changes were proposed in this PR?

Added another check/test to our pre-commit framework and updated the hooks

How was this patch tested?

Ran locally: pre-commit run --all-files

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the documentation.

@jbampton
Copy link
Member Author

jbampton commented Oct 8, 2024

@jbampton
Copy link
Member Author

jbampton commented Oct 8, 2024

@jiayuasu jiayuasu merged commit 82afeaf into apache:master Oct 8, 2024
3 checks passed
@jbampton jbampton deleted the pre-commit-update-add-hook branch October 8, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants