[ISSUE #7592] testCleanBuffer unit test modifies, changed non-direct … #7593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irect to direct buffer allocation
|
good catch |
lizhanhui
previously approved these changes
Nov 29, 2023
…is direct or not Signed-off-by: Li Zhanhui <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #7593 +/- ##
=============================================
+ Coverage 43.20% 43.22% +0.01%
- Complexity 9785 9790 +5
=============================================
Files 1162 1162
Lines 84376 84378 +2
Branches 10954 10955 +1
=============================================
+ Hits 36457 36469 +12
+ Misses 43394 43384 -10
Partials 4525 4525 ☔ View full report in Codecov by Sentry. |
lizhanhui
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…to direct buffer allocation
Which Issue(s) This PR Fixes
Fixes #7592
Brief Description
testCleanBuffer unit test modified, changed non-direct to direct buffer allocation
How Did You Test This Change?
using mvn test