-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #50] Feature add rocketmq exporter to nameserver #51
base: master
Are you sure you want to change the base?
Conversation
feature add rocketmq-exporter to cluster
Thanks for your contribution~
|
Design: If the exporter is used as an independent pod, when I have multiple nameservers, my exporter does not know which nameserver to connect, so I use exporter as an option of nameserver, deploy it as a sidecar to nameserver。Can you give me some design advice? |
In fact operator maintains a variable in the shared package named |
2) add how to user rocketmq-exporter
…etmq-operator into feature-code-review
ADD exporter image and document. Please check it. I tend to use the exporter as the sidecar of the nameserver. Please check the exporter's dockerfile. Because I tend to adjust the fields in the share package to private, so that multiple clusters can be deployed using one operator. If you still want to deploy the exporter separately, I will do as you say. thanks |
- name: ROCKETMQ_VERSION | ||
value: V4_3_2 | ||
- name: NAMESRV_ADDR | ||
value: 127.0.0.1:9876 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it better to init the NAMESRV_ADDR env in nameservice_controller.go
No description provided.