Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #50] Feature add rocketmq exporter to nameserver #51

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

linjiemiao
Copy link

No description provided.

@linjiemiao linjiemiao changed the title Feature add rocketmq exporter to Feature add rocketmq exporter to nameserver Sep 17, 2020
@liuruiyiyang
Copy link
Contributor

liuruiyiyang commented Sep 18, 2020

Thanks for your contribution~
There are several questions:

  1. Design. Since the exporter is an independent service, would it be better to deploy in an independent pod and be optional?
  2. Docker image. The image used by rocketmq-operator is better also open-sourced. So the dockerfile and other image related code should be added to our image package(dir) in general (or at least add some docs about how to build it). In that way we can build it, test it and push it to our official repository apacherocketmq.
  3. Documentation. It is better to add some documents/related links about how to use it in full functioning. In fact there are dependencies like Prometheus and Grafana.

@linjiemiao
Copy link
Author

Thanks for your contribution~
There are several questions:

  1. Design. Since the exporter is an independent service, would it be better to deploy in an independent pod and be optional?
  2. Docker image. The image used by rocketmq-operator is better also open-sourced. So the dockerfile and other image related code should be added to our image package(dir) in general (or at least add some docs about how to build it). In that way we can build it, test it and push it to our official repository apacherocketmq.
  3. Documentation. It is better to add some documents/related links about how to use it in full functioning. In fact there are dependencies like Prometheus and Grafana.

Design:

If the exporter is used as an independent pod, when I have multiple nameservers, my exporter does not know which nameserver to connect, so I use exporter as an option of nameserver, deploy it as a sidecar to nameserver。Can you give me some design advice?

@liuruiyiyang
Copy link
Contributor

liuruiyiyang commented Sep 18, 2020

Thanks for your contribution~
There are several questions:

  1. Design. Since the exporter is an independent service, would it be better to deploy in an independent pod and be optional?
  2. Docker image. The image used by rocketmq-operator is better also open-sourced. So the dockerfile and other image related code should be added to our image package(dir) in general (or at least add some docs about how to build it). In that way we can build it, test it and push it to our official repository apacherocketmq.
  3. Documentation. It is better to add some documents/related links about how to use it in full functioning. In fact there are dependencies like Prometheus and Grafana.

Design:

If the exporter is used as an independent pod, when I have multiple nameservers, my exporter does not know which nameserver to connect, so I use exporter as an option of nameserver, deploy it as a sidecar to nameserver。Can you give me some design advice?

In fact operator maintains a variable in the shared package named NameServersStr which is the NAMESRV_ADDR like: 192.168.1.1:9876;192.168.1.2:9876. You can check the code and use that.

@linjiemiao
Copy link
Author

Thanks for your contribution~
There are several questions:

  1. Design. Since the exporter is an independent service, would it be better to deploy in an independent pod and be optional?
  2. Docker image. The image used by rocketmq-operator is better also open-sourced. So the dockerfile and other image related code should be added to our image package(dir) in general (or at least add some docs about how to build it). In that way we can build it, test it and push it to our official repository apacherocketmq.
  3. Documentation. It is better to add some documents/related links about how to use it in full functioning. In fact there are dependencies like Prometheus and Grafana.

Design:
If the exporter is used as an independent pod, when I have multiple nameservers, my exporter does not know which nameserver to connect, so I use exporter as an option of nameserver, deploy it as a sidecar to nameserver。Can you give me some design advice?

In fact operator maintains a variable in the shared package named NameServersStr which is the NAMESRV_ADDR like: 192.168.1.1:9876;192.168.1.2:9876. You can check the code and use that.

ADD exporter image and document.

Please check it. I tend to use the exporter as the sidecar of the nameserver. Please check the exporter's dockerfile.

Because I tend to adjust the fields in the share package to private, so that multiple clusters can be deployed using one operator.

If you still want to deploy the exporter separately, I will do as you say.

thanks

@liuruiyiyang liuruiyiyang added the enhancement New feature or request label Sep 20, 2020
@liuruiyiyang liuruiyiyang changed the title Feature add rocketmq exporter to nameserver [ISSUE #50] Feature add rocketmq exporter to nameserver Sep 20, 2020
- name: ROCKETMQ_VERSION
value: V4_3_2
- name: NAMESRV_ADDR
value: 127.0.0.1:9876

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it better to init the NAMESRV_ADDR env in nameservice_controller.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants