Skip to content

Commit

Permalink
Polish code
Browse files Browse the repository at this point in the history
  • Loading branch information
aaron-ai committed Jul 15, 2022
1 parent cec1668 commit 3039621
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
1 change: 0 additions & 1 deletion .asf.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,3 @@ github:
projects: true
protected_branches:
main: {}

2 changes: 1 addition & 1 deletion .clang-format
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ Language: Proto
ColumnLimit: 120
SpacesInContainerLiterals: false
AllowShortFunctionsOnASingleLine: None
ReflowComments: false
ReflowComments: false
7 changes: 4 additions & 3 deletions ChangeLog.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
Changes:
# Changelog

1. v1 --> v2
2. rpc ReceiveMessage(ReceiveMessageRequest) returns (stream ReceiveMessageResponse) {}
3. Removed Nack RPC to honor ChangeInvisibleDuration RPC in consistent way;
Expand All @@ -8,7 +9,7 @@ Changes:
7. FIFO flags moved from HeartbeatRequest to ConsumerData
8. Removed MessageModel enumeration as concept of broadcasting is totally deprecated;
9. Enums field number = 0 is redefined to meet requirement [Each enum value should end with a semicolon, not a comma. Prefer prefixing enum values instead of surrounding them in an enclosing message. The zero value enum should have the suffix UNSPECIFIED.](https://developers.google.com/protocol-buffers/docs/style)
10. Nested enumerations are externalized due to the same guide item as above.
10. Nested enumerations are externalized due to the same guide item as above.

Remaining Issues:
How server publishes conf and conf changes to clients
How server publishes conf and conf changes to clients.
2 changes: 1 addition & 1 deletion java/VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.0.0-SNAPSHOT
2.0.0-SNAPSHOT

0 comments on commit 3039621

Please sign in to comment.