Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RATIS-2239. Publish build scans to develocity.apache.org #60

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Publish data about CI builds to develocity.apache.org.

https://issues.apache.org/jira/browse/RATIS-2239

How was this patch tested?

Same config file is already used for Ratis.

CI:
https://github.com/adoroszlai/ratis-thirdparty/actions/runs/12844214973

@adoroszlai adoroszlai self-assigned this Jan 18, 2025
@adoroszlai
Copy link
Contributor Author

@clayburn is it OK to use the same projectId as Ratis, since this repo belongs to the same TLP, or should it be unique per repo?

Copy link
Contributor

@szetszwo szetszwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the change looks good.

@clayburn
Copy link

@adoroszlai - either is fine, although I would lean towards "unique per repo". Projects are part of "groups", which in this case would correspond to the TLP, and much of the actual permissions can be managed there.

@adoroszlai adoroszlai merged commit 7e2d4c2 into apache:master Jan 23, 2025
1 check passed
@adoroszlai adoroszlai deleted the RATIS-2239 branch January 23, 2025 19:33
@adoroszlai
Copy link
Contributor Author

Thanks @clayburn, @szetszwo for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants