Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][alpine] thread stack size #23361

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yuweisung
Copy link

@yuweisung yuweisung commented Sep 27, 2024

Fixes 23348

Main Issue: #23348

Motivation

Alpine pthread stack size is too small. In some cases, the pod will be oomkilled due to "cannot create native thread".

Modifications

Add ENV in dockerfile

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

Copy link

@yuweisung Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Sep 27, 2024
@@ -19,6 +19,7 @@

ARG PULSAR_IMAGE
FROM busybox as pulsar-all
ENV PTHREAD_STACK_MIN 2097152
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a multi-stage image. The ENV is only effective in the final image if it's defined in the last stage.

@lhotari
Copy link
Member

lhotari commented Sep 28, 2024

Alpine pthread stack size is too small. In some cases, the pod will be oomkilled due to "cannot create native thread".

Please share more details of the error message so that it would be possible to find this PR by searching with the error message. It would be great to have a way to reproduce.

Please also share more context for reviewers so that a reviewer could read from some reference what this is about.

@lhotari
Copy link
Member

lhotari commented Sep 28, 2024

This would become obsolete with #23366

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants