Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix][broker][branch-2.10] Remove the unnecessary HTTP response header: Content-Encoding when calling getSchema #22307

Merged
merged 2 commits into from
Mar 20, 2024
Merged

[fix][broker][branch-2.10] Remove the unnecessary HTTP response header: Content-Encoding when calling getSchema #22307

merged 2 commits into from
Mar 20, 2024

Conversation

poorbarcode
Copy link
Contributor

@poorbarcode poorbarcode commented Mar 19, 2024 •
edited by lhotari
Loading

Motivation

curl -X GET https://127.0.0.1:443/admin/v2/schemas/public/default/tp1/schema 

Response:

HTTP/1.1 200 OK
Content-Encoding: application/json
Content-Type: application/json
Server: Jetty(9.4.51.v20230217)
Content-Length: 403

The HTTP response header Content-Encoding is wrong and unnecessary. The other branches have been fixed by #16018 and can not cherry-pick into branch-2.10, see detail here

Modifications

Remove the unnecessary HTTP response header: Content-Encoding

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: x

@poorbarcode poorbarcode self-assigned this Mar 19, 2024
@poorbarcode poorbarcode added type/bug The PR fixed a bug or issue reported a bug cherry-picked/branch-2.10 release/2.10.7 labels Mar 19, 2024
@poorbarcode poorbarcode added this to the 3.3.0 milestone Mar 19, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Mar 19, 2024
@lhotari lhotari changed the title [fix] [broker] Remove the unnecessary HTTP response header: Content_Encoding when calling getSchema [fix] [broker] Remove the unnecessary HTTP response header: Content-Encoding when calling getSchema Mar 19, 2024
lhotari
lhotari approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@poorbarcode poorbarcode changed the title [fix] [broker] Remove the unnecessary HTTP response header: Content-Encoding when calling getSchema [fix] [broker] [branch-2.10] Remove the unnecessary HTTP response header: Content-Encoding when calling getSchema Mar 20, 2024
@poorbarcode poorbarcode merged commit 838c0c3 into apache:branch-2.10 Mar 20, 2024
28 checks passed
@lhotari lhotari changed the title [fix] [broker] [branch-2.10] Remove the unnecessary HTTP response header: Content-Encoding when calling getSchema [fix][broker][branch-2.10] Remove the unnecessary HTTP response header: Content-Encoding when calling getSchema Mar 27, 2024
@lhotari lhotari removed this from the 3.3.0 milestone Mar 27, 2024
nodece pushed a commit to ascentstream/pulsar that referenced this pull request May 13, 2024
@poorbarcode @nodece
[fix] [broker] [branch-2.10] Remove the unnecessary HTTP response hea…
357ee8c 
…der: Content-Encoding when calling getSchema (apache#22307)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhotari lhotari lhotari approved these changes

@Technoboy- Technoboy- Technoboy- approved these changes

@coderzc coderzc coderzc approved these changes

@liangyepianzhou liangyepianzhou liangyepianzhou approved these changes

Assignees

@poorbarcode poorbarcode

Labels
cherry-picked/branch-2.10 doc-not-needed Your PR changes do not impact docs release/2.10.7 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@poorbarcode @lhotari @Technoboy- @coderzc @liangyepianzhou