Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor][client] Remove cpp and python client in 2.10 #20975

Closed
wants to merge 11 commits into from

Conversation

liangyepianzhou
Copy link
Contributor

Motivation

The cpp client and python client have been removed to https://github.com/apache/pulsar-client-cpp and https://github.com/apache/pulsar-client-python. It should be excluded from branch-2.10 now.

Modifications

Remove cpp client and python client in branch-2.10.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-complete Your PR changes impact docs and the related docs have been already added. label Aug 11, 2023
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need to update the CI workflow and check suite (.asf.yaml) also.

@liangyepianzhou
Copy link
Contributor Author

image Integration tests seem to require building a Python instant.

@liangyepianzhou
Copy link
Contributor Author

Close this via #20981

@BewareMyPower BewareMyPower deleted the remove_cpp_python branch August 14, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-complete Your PR changes impact docs and the related docs have been already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants