-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][broker] allow client skips the non-continued deleted ranges stats #18263
Conversation
maybe we should use GetStatsOptions next pr, not original name like getPreciseBacklog,subscriptionBacklogSize etc. |
@leizhiyuan Please add the following content to your PR description and select a checkbox:
|
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java
Outdated
Show resolved
Hide resolved
There is a failed broker test in your leizhiyuan#4 : if it is caused by your change please fix it. |
I didn't sync the master branch ,now I opened a new pr |
Add some case seems be flaky, It is not related with the pr, I ran ok in my machine。 |
/pulsarbot run-failure-checks |
Codecov Report
@@ Coverage Diff @@
## master #18263 +/- ##
============================================
+ Coverage 38.84% 44.71% +5.87%
- Complexity 8286 10591 +2305
============================================
Files 683 748 +65
Lines 67323 73915 +6592
Branches 7215 8167 +952
============================================
+ Hits 26152 33052 +6900
+ Misses 38210 37169 -1041
- Partials 2961 3694 +733
Flags with carried forward coverage won't be shown. Click here to find out more.
|
...er/src/test/java/org/apache/pulsar/broker/resourcegroup/RGUsageMTAggrWaitForAllMsgsTest.java
Show resolved
Hide resolved
.../src/test/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupUsageAggregationTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I left some comments. Please help to confirm.
The pr had no activity for 30 days, mark with Stale label. |
@leizhiyuan could you please merge the |
The pr had no activity for 30 days, mark with Stale label. |
@leizhiyuan could you please rebase master and take a look at the failed tests? |
The pr had no activity for 30 days, mark with Stale label. |
please rebase. |
related to #23380 |
It's been too long (2 years) since the pull request. I can't even remember some of the code at that time. I will close this PR. |
Fixes #18240
Master Issue: #18240
Motivation
Modifications
add a flag getTotalNonContiguousDeletedMessagesRange to allow users can skip the non-continued deleted ranges stats
Verifying this change
leizhiyuan#5
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: