Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getUriPath logic to ignore API tenant base path #363

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Fix getUriPath logic to ignore API tenant base path #363

merged 1 commit into from
Apr 1, 2020

Conversation

hasueki
Copy link
Contributor

@hasueki hasueki commented Oct 23, 2019

Connects to #362

This change will ignore /api/<tenant> when matching the original URI and computing the backend URI.

  • Strip /api/<tenant> when computing backend URI
  • Extract out getUriPath for unit testing
  • Add unit test
  • Update README.md "Testing" make cmd

PTAL: @mhamann @rabbah

@rabbah
Copy link
Member

rabbah commented Oct 24, 2019

Thanks @hasueki.

@chetanmeh FYI.

mhamann
mhamann approved these changes Oct 24, 2019
View reviewed changes
Copy link
Member

@mhamann mhamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hasueki I think this looks good. It would also be good to write a test to see if a backend url of / would work with this change.

@mhamann mhamann merged commit ca0fae0 into apache:master Apr 1, 2020
@dgrove-oss dgrove-oss mentioned this pull request Apr 2, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhamann mhamann mhamann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hasueki @rabbah @mhamann