-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples/mqttc: add option to use MBED TLS for connections #2643
Conversation
28fc726
to
493d286
Compare
[Experimental Bot, please feedback here] The PR summary is missing some key information:
Impact:
Testing:
In conclusion, this PR does not yet meet the NuttX requirements. You need to address the missing information and expand on the testing before it can be considered for merging. |
493d286
to
0ada597
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @pkarashchenko :-)
- Can you please update also the documentation part so everyone knows that MQTT + TLS is supported?
- What happens when self-signed certificate is in use? How can we control reaction to that situation? Shall we create a dedicated CONFIG variable to accept self-signed certificates during development? In general self-signed certificates on a production system indicates compromised channel so we should not allow that by default :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @pkarashchenko :-)
Ci check is a GH worker problem.
Please consider adding documentation in a free moment, especially the self-signed certificates handling / warning / errors :-)
Let me update the PR |
@pkarashchenko please rebase to the latest master to fix check error. |
Signed-off-by: Petro Karashchenko <[email protected]>
0ada597
to
7940c38
Compare
@cederom I added |
Let's ignore |
@pkarashchenko please include a board profile, for example sim:mqtt_tls |
Will do. As well as a docs update |
Summary
Add mbedTLS option to
examples/mqttc
.I haven't tried to connect with this code exactly to
"broker.hivemq.com"
, so example may not work as is (somebody needs to try), but I used this code to connect to other MQTT server with TLS.This code has some advantages compared to native MQTT-C
mbedtls_sockets.h
implementation in the way that it tolerates self-signed certificates on a server (usually useful during development).Impact
Extend MQTT-C example
Testing
Tested on ESP32-S3, but connecting to custom MQTT provider service