Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update samples. move battery dump to system, fix problems report by coverity(unsigned compare with 0) #2614

Merged
merged 5 commits into from
Sep 30, 2024

Conversation

jasonbu
Copy link
Contributor

@jasonbu jasonbu commented Sep 27, 2024

Summary

Add example for wakeup gpio type.
Update regulator samples.
move battery dump to system.
fix pmconfig command catched issue reported by coverity(unsigned compare with 0)

Impact

more samples,
batterydump now regard as a tool, not a test

Testing

CI-test.

@nuttxpr
Copy link

nuttxpr commented Sep 27, 2024

[Experimental Bot, please feedback here]

This PR does not meet the NuttX requirements.

Here's why:

  • Summary is incomplete:
    • It lacks details about the necessity, functionality changes, and working mechanism of the change.
    • It doesn't mention related issues or pull requests.
  • Impact section lacks details:
    • Simply stating "No" for all impact points is insufficient. Even if there's no impact, a brief explanation is helpful for reviewers.
  • Testing is insufficient:
    • "CI-test" is not descriptive enough.
    • You need to provide:
      • Specific build host and target details (OS, architecture, board, configuration).
      • Relevant testing logs from before and after the change to demonstrate the issue and the fix.

To improve this PR:

  1. Expand the Summary: Provide specific details about the change's purpose, affected code, and how it works. Include links to related issues/PRs.
  2. Elaborate on Impact: Even if there's no impact in most areas, briefly explain why. For example, "No impact on build process as the change is limited to documentation."
  3. Provide Detailed Testing Information:
    • List the specific build hosts (OS, CPU, compiler) and targets (architecture, board, configuration) used for testing.
    • Include relevant snippets of testing logs from before and after the change, clearly showing the problem and the solution.

@jasonbu jasonbu marked this pull request as draft September 27, 2024 12:12
@cederom
Copy link

cederom commented Sep 27, 2024

Please update PR description Summary/Impact/Testing according to bot suggestions.

dulibo1 added 5 commits September 30, 2024 14:11
from the cmocka.h:
 * These headers or their equivalents MUST be included prior to including
 * this header file.
 * @code
 * #include <stdarg.h>
 * #include <stddef.h>
 * #include <stdint.h>
 * #include <setjmp.h>
 * @Endcode

Signed-off-by: dulibo1 <[email protected]>
Signed-off-by: buxiasen <[email protected]>
@jasonbu jasonbu marked this pull request as ready for review September 30, 2024 08:30
@xiaoxiang781216 xiaoxiang781216 merged commit b20f023 into apache:master Sep 30, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants