Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ymodem:set the transport retry as optional #2611

Merged
merged 2 commits into from
Sep 28, 2024

Conversation

anjiahao1
Copy link
Contributor

Summary

The waiting duration of the rb/sb command can be determined based on the number of retransmissions, so that ymodem can restart to the normal system after running in the bootloader for a short period of time.

Impact

ymodem

Testing

use stm32 ymodem

@nuttxpr
Copy link

nuttxpr commented Sep 27, 2024

[Experimental Bot, please feedback here]

NuttX PR Requirements Review

Verdict: The PR does not fully meet NuttX requirements.

Missing Information:

  • Summary:
    • Lacks clarity on why this change is necessary. What problem does it solve?
    • Needs specifics on how the waiting duration is calculated.
    • Should mention which functional part of the code is modified (e.g., ymodem driver).
  • Impact:
    • Unclear if this is a new feature or modification.
    • Does this change user interaction with ymodem?
    • Potential impact on compatibility (backward/forward) is not addressed.
  • Testing:
    • Insufficient detail.
    • Provide:
      • Specific build host details (OS, CPU, compiler version).
      • Target architecture, board, and configuration.
      • Actual testing logs before and after the change.

Recommendations:

  1. Expand the Summary: Clearly articulate the problem, the solution (including calculation details), and the affected code section.
  2. Complete the Impact Section: Address all points, especially user impact and compatibility concerns.
  3. Provide Detailed Testing Information: Include specific host/target setups and relevant log snippets.

The waiting duration of the rb/sb command can be determined based on
the number of retransmissions, so that ymodem can restart to the normal
system after running in the bootloader for a short period of time.

Signed-off-by: anjiahao <[email protected]>
Copy link

@cederom cederom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @anjiahao1 :-)

@xiaoxiang781216 xiaoxiang781216 merged commit 55df301 into apache:master Sep 28, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants