Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nimble/host/src/ble_gap.c: undefined SET_BIT before defining it. #1861

Merged
merged 1 commit into from
Sep 18, 2024
Merged

nimble/host/src/ble_gap.c: undefined SET_BIT before defining it. #1861

merged 1 commit into from
Sep 18, 2024

Conversation

dmainz
Copy link
Contributor

@dmainz dmainz commented Sep 14, 2024

Was getting duplicate definitions of SET_BIT when compiling for an STM32F4 device.

@github-actions github-actions bot added host size/XS Extra small PR labels Sep 14, 2024
sjanc
sjanc approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@sjanc sjanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this for time being, in long term we should have common helpers for this

@dmainz
Copy link
Contributor Author

dmainz commented Sep 18, 2024

Can you point me to an example of a helper?

@sjanc sjanc merged commit 1962ba1 into apache:master Sep 18, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjanc sjanc sjanc approved these changes

@andrzej-kaczmarek andrzej-kaczmarek Awaiting requested review from andrzej-kaczmarek

Assignees
No one assigned
Labels
host size/XS Extra small PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmainz @sjanc