Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restored binary serialization on net8.0 and deprecated it to match the BCL (fixes #983) #993

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

NightOwl888
Copy link
Contributor

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a change, please open an issue to discuss the change or find an existing issue.

Restored binary serialization and deprecated it to match the BCL

Fixes #983

We deprecated binary serialization support on all target frameworks, not just net8.0, but left it fully functional for those who still depend on it. This also updates the .runtime.config file for each of the test projects so the binary serialization tests will run.

…ods obsolete and hidden from the IDE. Also suppressed related build warnings, since we are doing this on all target frameworks. (fixes apache#983)
@NightOwl888 NightOwl888 added this to the 4.8.0-beta00017 milestone Oct 23, 2024
@paulirwin paulirwin merged commit d970d58 into apache:master Oct 23, 2024
199 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Fix serialization tests and deprecate (rather than exclude) serialization support to match the BCL
2 participants