Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShingleFilter produces invalid queries #946

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Conversation

tohidemyname
Copy link
Contributor

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Fixes #{bug number} (in this specific format)
#943

Description

{Detail}

@paulirwin
Copy link
Contributor

@tohidemyname Thanks, also, for this PR!

This appears to be a fairly faithful port of this fix in Lucene 6.5: apache/lucene@57a42e4

Just like #947, we'll need to polish a couple things to our conventions like the test name. I'll do that work as part of merging.

cc @NightOwl888

Copy link
Contributor

@NightOwl888 NightOwl888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this Paul.

This looks good to merge.

@paulirwin paulirwin merged commit ca3bdac into apache:master Nov 4, 2024
197 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants