Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review of Lucene.Net.Tests.Queries (See #259) #432

Merged
merged 7 commits into from
Feb 22, 2021
Merged

Review of Lucene.Net.Tests.Queries (See #259) #432

merged 7 commits into from
Feb 22, 2021

Commits on Feb 22, 2021

  1. Lucene.Net.Tests.Queries: Use consistent license headers (apache#259)

    @NightOwl888
    NightOwl888 committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    5f63bbe View commit details
    Browse the repository at this point in the history

  2. Lucene.Net.Tests.Queries: Removed unused imports (apache#259)

    @NightOwl888
    NightOwl888 committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    78f07cf View commit details
    Browse the repository at this point in the history

  3. BUG: Lucene.Net.Tests.Queries.Function.TestFieldScoreQuery: Added mis… 

    …sing [Test] attributes (apache#259)
    @NightOwl888
    NightOwl888 committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    10870c9 View commit details
    Browse the repository at this point in the history

  4. SWEEP: MemberwiseClone() doesn't throw exceptions in .NET, so there i… 

    …s no need to place it in a try/catch block. There is also no need to cast the result if we don't need access to its members. (apache#259)
    @NightOwl888
    NightOwl888 committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    f065f81 View commit details
    Browse the repository at this point in the history

  5. Lucene.Net.Index.Term: Added TODO about converting Text() to a proper… 

    …ty (apache#259)
    @NightOwl888
    NightOwl888 committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    08c44cf View commit details
    Browse the repository at this point in the history

  6. BUG: Lucene.Net.Tests.Queries.TermsFilterTest::TestSingleFieldEquals(… 

    …): Hash code collision provided in Lucene won't necessarily be a collision in .NET. Generate the collision at runtime so the test will pass (the test wouldn't have passed if the assert hadn't been commented). (apache#259)
    @NightOwl888
    NightOwl888 committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    e499652 View commit details
    Browse the repository at this point in the history

  7. Lucene.Net.Queries, Lucene.Net.Tests.Queries: Marked lucene compatibi… 

    …lity version 4.8.1 at the top of each file. (apache#259)
    @NightOwl888
    NightOwl888 committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    de45ee5 View commit details
    Browse the repository at this point in the history