PERFORMANCE: Lucene.Net.Analysis.TokenAttributes.CharTermAttribute::A…

…ppend(): Use StringBuilder.CopyTo() to copy the chars instead of allocating a string.
apache · Jan 19, 2024 · d740f13 · d740f13
1 parent 8c3af72
commit d740f13
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/src/Lucene.Net/Analysis/TokenAttributes/CharTermAttributeImpl.cs b/src/Lucene.Net/Analysis/TokenAttributes/CharTermAttributeImpl.cs
@@ -279,7 +279,10 @@ public CharTermAttribute Append(StringBuilder value)
                 return this; // No-op
             }
 
-            return Append(value.ToString());
+            int len = value.Length;
+            value.CopyTo(0, InternalResizeBuffer(termLength + len), termLength, len);
+            Length += len;
+            return this;
         }
 
         public CharTermAttribute Append(StringBuilder value, int startIndex, int charCount)
@@ -301,7 +304,9 @@ public CharTermAttribute Append(StringBuilder value, int startIndex, int charCou
             if (startIndex > value.Length - charCount)
                 throw new ArgumentOutOfRangeException(nameof(startIndex), $"Index and length must refer to a location within the string. For example {nameof(startIndex)} + {nameof(charCount)} <= {nameof(Length)}.");
 
-            return Append(value.ToString(startIndex, charCount));
+            value.CopyTo(startIndex, InternalResizeBuffer(termLength + charCount), termLength, charCount);
+            Length += charCount;
+            return this;
         }
 
         public CharTermAttribute Append(ICharTermAttribute value)