[linkis-web-next]: Modules refactoring & Bug fixing #5145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
|
Please modify the PR description and title. |
Linhao-Qian
changed the title
Linhao-Qian
changed the title
Linhao-Qian
changed the title
peacewong
reviewed
Jul 22, 2024
Linhao-Qian
changed the title
mayinrain
reviewed
Jul 29, 2024
| return; | ||
| } | ||
| for (const cate of tmpData.value.childCategory) { | ||
| try { |
There was a problem hiding this comment.
If there are no chain dependencies in the requests here, it might be more efficient to use Promise.all to execute them in parallel.
There was a problem hiding this comment.
It would be better if similar logic could be wrapped into a function.
mayinrain
reviewed
Jul 29, 2024
|
|
||
| const props = defineProps<{ | ||
| name: string; | ||
| description: string; | ||
| dataList: DataList; | ||
| dataList: any; |
There was a problem hiding this comment.
Try to avoid using the any type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Hello maintainers, I am in charge of the linkis-web-next development and refactoring. I submitted the PR to Apache Linkis, aiming to refactor linkis-web-next modules. Besides, considering that there are a lot of bugs in the linkis-web-next project, I also fixed some of them. I hope my codes could provide users of linkis-web with a better experience in the future~
Until now, I have already refactored these modules in linkis-web-next projects:
Welcome to give feedback on my codes, thank you~