[WIP] Flink supports k8s operator submit task #4902
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarexixi
reviewed
Sep 13, 2023
| } | ||
|
|
||
| public FlinkDeployment getFlinkDeployment(String name, String namespace) { | ||
| FlinkDeployment FlinkDeployment = new FlinkDeployment(); |
There was a problem hiding this comment.
FlinkDeployment flinkDeployment = ...
rarexixi
reviewed
Sep 13, 2023
| CustomResourceDefinitionList crds = | ||
| client.apiextensions().v1().customResourceDefinitions().list(); | ||
|
|
||
| String FlinkDeploymentCRDName = CustomResource.getCRDName(FlinkDeployment.class); |
There was a problem hiding this comment.
String flinkDeploymentCRDName = ...
rarexixi
reviewed
Sep 13, 2023
| public void startFlinkKubernetesOperatorWatcher() { | ||
| getFlinkDeploymentClient() | ||
| .inNamespace(this.config.getK8sNamespace()) | ||
| .withName(this.config.getFlinkAppName()) |
There was a problem hiding this comment.
Consider replacing with label ticket-id
There was a problem hiding this comment.
Ok, thanks for reviewing the code
rarexixi
reviewed
Sep 13, 2023
| FlinkDeployment FlinkDeployment = new FlinkDeployment(); | ||
| ObjectMeta metadata = new ObjectMeta(); | ||
| metadata.setName(name); | ||
| metadata.setNamespace(namespace); |
There was a problem hiding this comment.
Set some labels here (like "from-app": "linkis", "linkis-ticket-id": ${ticketId})
peacewong
reviewed
Oct 10, 2023
| * {@link Diffable} classes can be compared with other {@link Diffable} objects for differences. | ||
| * | ||
| * <p>Inspired by: | ||
| * https://github.com/apache/commons-lang/blob/master/src/main/java/org/apache/commons/lang3/builder/Diffable.java |
There was a problem hiding this comment.
Ok, thanks for reviewing the code
ChengJie1053
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flink supports k8s operator submit task