Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][linkis-public-enhancements] merge pes common module #4848

Closed
wants to merge 3 commits into from

Conversation

GuoPhilipse
Copy link
Member

What is the purpose of the change

current we have too many modules, we can merge some common code together

Related issues/PRs

Related issues: #4846
Related pr:#4848

Brief change log

1、merge common modules of bml、contextservice、datasource module、error-code common、udfcommon、context-Service-listener to be linkis-pes-common common
2、upgrade commons-lang2 -> commons-lang3

Checklist

  • I have read the Contributing Guidelines on pull requests.
  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the Linkis mailing list first)
  • If this is a code change: I have written unit tests to fully verify the new behavior.

2、optimize pes-common module,reduce too many modules
2、optimize pes-common module,reduce too many modules
@@ -35,7 +35,7 @@
</dependency>
<dependency>
<groupId>org.apache.linkis</groupId>
<artifactId>linkis-cs-common</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cs-listener need to merge to pes common


<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-lang3</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can remove this, for linkis-common module had import


public enum OperateType {

/** 对contextKey和contextId的一些操作 */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use enginlish

@GuoPhilipse GuoPhilipse closed this Aug 7, 2023
@GuoPhilipse GuoPhilipse deleted the merge-pes-module branch August 7, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants